6a0f119fc2
This test failure from #92 inspired this change: https://travis-ci.org/bitly/google_auth_proxy/jobs/62425336 2015/05/13 16:27:33 using authenticated emails file /tmp/test_auth_emails_952353477 2015/05/13 16:27:33 watching /tmp/test_auth_emails_952353477 for updates 2015/05/13 16:27:33 validating: is xyzzy@example.com valid? true 2015/05/13 16:27:33 watching interrupted on event: "/tmp/test_auth_emails_952353477": CHMOD 2015/05/13 16:27:33 watching resumed for /tmp/test_auth_emails_952353477 2015/05/13 16:27:33 reloading after event: "/tmp/test_auth_emails_952353477": CHMOD 2015/05/13 16:27:33 watching interrupted on event: "/tmp/test_auth_emails_952353477": REMOVE 2015/05/13 16:27:33 validating: is xyzzy@example.com valid? false 2015/05/13 16:27:33 watching resumed for /tmp/test_auth_emails_952353477 2015/05/13 16:27:33 reloading after event: "/tmp/test_auth_emails_952353477": REMOVE 2015/05/13 16:27:33 failed opening authenticated-emails-file="/tmp/test_auth_emails_952353477", open /tmp/test_auth_emails_952353477: no such file or directory I believe that what happened was that the call to reload the file after the second "reloading after event" lost the race when the test shut down and the file was removed. This change introduces a `done` channel that ensures outstanding actions complete and the watcher exits before the test removes the file.
50 lines
1.2 KiB
Go
50 lines
1.2 KiB
Go
// +build go1.3
|
|
// +build !plan9,!solaris,!windows
|
|
|
|
// Turns out you can't copy over an existing file on Windows.
|
|
|
|
package main
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
func (vt *ValidatorTest) UpdateEmailFileViaCopyingOver(
|
|
t *testing.T, emails []string) {
|
|
orig_file := vt.auth_email_file
|
|
var err error
|
|
vt.auth_email_file, err = ioutil.TempFile("", "test_auth_emails_")
|
|
if err != nil {
|
|
t.Fatal("failed to create temp file for copy: " + err.Error())
|
|
}
|
|
vt.WriteEmails(t, emails)
|
|
err = os.Rename(vt.auth_email_file.Name(), orig_file.Name())
|
|
if err != nil {
|
|
t.Fatal("failed to copy over temp file: " + err.Error())
|
|
}
|
|
vt.auth_email_file = orig_file
|
|
}
|
|
|
|
func TestValidatorOverwriteEmailListViaCopyingOver(t *testing.T) {
|
|
vt := NewValidatorTest(t)
|
|
defer vt.TearDown()
|
|
|
|
vt.WriteEmails(t, []string{"xyzzy@example.com"})
|
|
domains := []string(nil)
|
|
updated := make(chan bool)
|
|
validator := vt.NewValidator(domains, updated)
|
|
|
|
if !validator("xyzzy@example.com") {
|
|
t.Error("email in list should validate")
|
|
}
|
|
|
|
vt.UpdateEmailFileViaCopyingOver(t, []string{"plugh@example.com"})
|
|
<-updated
|
|
|
|
if validator("xyzzy@example.com") {
|
|
t.Error("email removed from list should not validate")
|
|
}
|
|
}
|