7a8fb58ad1
Fix an unsupported protocol scheme error when validating tokens by
ensuring that the ValidateURL generates a non-empty string. The Azure
provider doesn't define any ValidateURL and therefore uses the default
value of `url.Parse("")` which is not `nil`.
The following log summary shows the issue:
2019/06/14 12:26:04 oauthproxy.go:799: 10.244.1.3:34112 ("10.244.1.1") refreshing 16h26m29s old session cookie for Session{email:jonas.fonseca@example.com user:jonas.fonseca token:true} (refresh after 1h0m0s)
2019/06/14 12:26:04 internal_util.go:60: GET ?access_token=eyJ0...
2019/06/14 12:26:04 internal_util.go:61: token validation request failed: Get ?access_token=eyJ0...: unsupported protocol scheme ""
2019/06/14 12:26:04 oauthproxy.go:822: 10.244.1.3:34112 ("10.244.1.1") removing session. error validating Session{email:jonas.fonseca@example.com user:jonas.fonseca token:true}
75 lines
2.0 KiB
Go
75 lines
2.0 KiB
Go
package providers
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"net/http"
|
|
"net/url"
|
|
|
|
"github.com/pusher/oauth2_proxy/api"
|
|
"github.com/pusher/oauth2_proxy/logger"
|
|
)
|
|
|
|
// stripToken is a helper function to obfuscate "access_token"
|
|
// query parameters
|
|
func stripToken(endpoint string) string {
|
|
return stripParam("access_token", endpoint)
|
|
}
|
|
|
|
// stripParam generalizes the obfuscation of a particular
|
|
// query parameter - typically 'access_token' or 'client_secret'
|
|
// The parameter's second half is replaced by '...' and returned
|
|
// as part of the encoded query parameters.
|
|
// If the target parameter isn't found, the endpoint is returned
|
|
// unmodified.
|
|
func stripParam(param, endpoint string) string {
|
|
u, err := url.Parse(endpoint)
|
|
if err != nil {
|
|
logger.Printf("error attempting to strip %s: %s", param, err)
|
|
return endpoint
|
|
}
|
|
|
|
if u.RawQuery != "" {
|
|
values, err := url.ParseQuery(u.RawQuery)
|
|
if err != nil {
|
|
logger.Printf("error attempting to strip %s: %s", param, err)
|
|
return u.String()
|
|
}
|
|
|
|
if val := values.Get(param); val != "" {
|
|
values.Set(param, val[:(len(val)/2)]+"...")
|
|
u.RawQuery = values.Encode()
|
|
return u.String()
|
|
}
|
|
}
|
|
|
|
return endpoint
|
|
}
|
|
|
|
// validateToken returns true if token is valid
|
|
func validateToken(p Provider, accessToken string, header http.Header) bool {
|
|
if accessToken == "" || p.Data().ValidateURL == nil || p.Data().ValidateURL.String() == "" {
|
|
return false
|
|
}
|
|
endpoint := p.Data().ValidateURL.String()
|
|
if len(header) == 0 {
|
|
params := url.Values{"access_token": {accessToken}}
|
|
endpoint = endpoint + "?" + params.Encode()
|
|
}
|
|
resp, err := api.RequestUnparsedResponse(endpoint, header)
|
|
if err != nil {
|
|
logger.Printf("GET %s", stripToken(endpoint))
|
|
logger.Printf("token validation request failed: %s", err)
|
|
return false
|
|
}
|
|
|
|
body, _ := ioutil.ReadAll(resp.Body)
|
|
resp.Body.Close()
|
|
logger.Printf("%d GET %s %s", resp.StatusCode, stripToken(endpoint), body)
|
|
|
|
if resp.StatusCode == 200 {
|
|
return true
|
|
}
|
|
logger.Printf("token validation request failed: status %d - %s", resp.StatusCode, body)
|
|
return false
|
|
}
|