meutel/oauth2_proxy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Clean up persistent SessionStore tests

Browse Source
This commit is contained in:
Joel Speed 2019-05-16 17:25:41 +01:00
parent 0ca05bd05b
commit b770aeca63
No known key found for this signature in database
GPG Key ID: 6E80578D6751DEFB
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/sessions/session_store_test.go
View File

@ -122,7 +122,7 @@ var _ = Describe("NewSessionStore", func() {
Expect(err).ToNot(HaveOccurred()) Expect(err).ToNot(HaveOccurred())
}) })
It("sets a `set-cookie` header in the response and session to not be loadable after clear", func() { It("sets a `set-cookie` header in the response", func() {
Expect(response.Header().Get("Set-Cookie")).ToNot(BeEmpty()) Expect(response.Header().Get("Set-Cookie")).ToNot(BeEmpty())
}) })
@ -169,8 +169,9 @@ var _ = Describe("NewSessionStore", func() {
}) })
} }
// The following should only be for server stores
PersistentSessionStoreTests := func() { PersistentSessionStoreTests := func() {
Context("when Clear is called the session should not be recoverable", func() { Context("when Clear is called on a persistent store", func() {
var loadedAfterClear *sessionsapi.SessionState var loadedAfterClear *sessionsapi.SessionState
BeforeEach(func() { BeforeEach(func() {
req := httptest.NewRequest("GET", "http://example.com/", nil) req := httptest.NewRequest("GET", "http://example.com/", nil)
@ -185,16 +186,21 @@ var _ = Describe("NewSessionStore", func() {
err = ss.Clear(response, request) err = ss.Clear(response, request)
Expect(err).ToNot(HaveOccurred()) Expect(err).ToNot(HaveOccurred())
// The following should only be for server stores
loadReq := httptest.NewRequest("GET", "http://example.com/", nil) loadReq := httptest.NewRequest("GET", "http://example.com/", nil)
for _, c := range resultCookies { for _, c := range resultCookies {
loadReq.AddCookie(c) loadReq.AddCookie(c)
} }
loadedAfterClear, err = ss.Load(loadReq) loadedAfterClear, err = ss.Load(loadReq)
// If we have cleared the session, Load should fail
Expect(err).To(HaveOccurred())
}) })
It("sets a `set-cookie` header in the response and session to not be loadable after clear", func() { It("sets a `set-cookie` header in the response", func() {
Expect(response.Header().Get("Set-Cookie")).ToNot(BeEmpty()) Expect(response.Header().Get("Set-Cookie")).ToNot(BeEmpty())
})
It("attempting to Load returns an empty session", func() {
Expect(loadedAfterClear).To(BeNil()) Expect(loadedAfterClear).To(BeNil())
}) })