meutel/oauth2_proxy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Cleanup in comments, removal of GetEmailAddress, use groups as []string

Browse Source
This commit is contained in:
Lukasz Leszczuk 2019-09-09 19:25:56 +02:00
parent e7b8acae0f
commit 3ff441026c
9 changed files with 33 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
oauthproxy.go
View File

@ -673,11 +673,9 @@ func (p *OAuthProxy) OAuthCallback(rw http.ResponseWriter, req *http.Request) {
return
}
groupNames := []string{}
for groupName := range groups {
groupNames = append(groupNames, groupName)
session.Groups = append(session.Groups, groupName)
}
session.Groups = strings.Join(groupNames, p.GroupsDelimiter)
}
if !p.IsValidRedirect(redirect) {
@ -849,8 +847,8 @@ func (p *OAuthProxy) addHeadersForProxying(rw http.ResponseWriter, req *http.Req
} else {
req.Header.Del("X-Forwarded-Email")
}
if p.PassGroups && session.Groups != "" {
req.Header["X-Forwarded-Groups"] = []string{session.Groups}
if p.PassGroups && len(session.Groups) != 0 {
req.Header["X-Forwarded-Groups"] = []string{strings.Join(session.Groups, p.GroupsDelimiter)}
}
}
@ -878,8 +876,8 @@ func (p *OAuthProxy) addHeadersForProxying(rw http.ResponseWriter, req *http.Req
rw.Header().Del("X-Auth-Request-Access-Token")
}
}
if p.PassGroups && session.Groups != "" {
rw.Header().Set("X-Auth-Request-Groups", session.Groups)
if p.PassGroups && len(session.Groups) != 0 {
rw.Header().Set("X-Auth-Request-Groups", strings.Join(session.Groups, p.GroupsDelimiter))
}
}

17
pkg/apis/sessions/session_state.go
View File

@ -20,7 +20,8 @@ type SessionState struct {
Email string `json:",omitempty"`
User string `json:",omitempty"`
ID string `json:",omitempty"`
Groups string `json:",omitempty"`
Groups []string `json:",omitempty"`
EncodedGroups string `json:",omitempty"`
}
// SessionStateJSON is used to encode SessionState into JSON without exposing time.Time zero value
@ -64,8 +65,8 @@ func (s *SessionState) String() string {
if s.RefreshToken != "" {
o += " refresh_token:true"
}
if s.Groups != "" {
o += fmt.Sprintf(" group:%s", s.Groups)
if len(s.Groups) != 0 {
o += fmt.Sprintf(" group:%s", strings.Join(s.Groups, ","))
}
return o + "}"
}
@ -110,11 +111,12 @@ func (s *SessionState) EncodeSessionState(c *encryption.Cipher) (string, error)
return "", err
}
}
if ss.Groups != "" {
ss.Groups, err = c.Encrypt(ss.Groups)
if len(ss.Groups) != 0 {
ss.EncodedGroups, err = c.Encrypt(strings.Join(ss.Groups, ","))
if err != nil {
return "", err
}
ss.Groups = nil
}
if ss.ID != "" {
ss.ID, err = c.Encrypt(ss.ID)
@ -252,11 +254,12 @@ func DecodeSessionState(v string, c *encryption.Cipher) (*SessionState, error) {
return nil, err
}
}
if ss.Groups != "" {
ss.Groups, err = c.Decrypt(ss.Groups)
if ss.EncodedGroups != "" {
groupsString, err := c.Decrypt(ss.EncodedGroups)
if err != nil {
return nil, err
}
ss.Groups = strings.Split(groupsString, ",")
}
if ss.ID != "" {
ss.ID, err = c.Decrypt(ss.ID)

4
providers/azure.go
View File

@ -255,11 +255,13 @@ func (p *AzureProvider) ValidateGroupWithSession(s *sessions.SessionState) bool
if len(p.PermittedGroups) == 0 {
return true
}
for _, group := range s.Groups {
for _, groupID := range p.PermittedGroups {
if strings.Contains(s.Groups, groupID) {
if strings.Contains(group, groupID) {
return true
}
}
}
return false
}

2
providers/facebook.go
View File

@ -54,7 +54,7 @@ func getFacebookHeader(accessToken string) http.Header {
return header
}
// GetEmailAddress returns the Account email address
// GetUserDetails returns the Account email address
func (p *FacebookProvider) GetUserDetails(s *sessions.SessionState) (*UserDetails, error) {
if s.AccessToken == "" {
return nil, errors.New("missing access token")

2
providers/github.go
View File

@ -200,7 +200,7 @@ func (p *GitHubProvider) hasOrgAndTeam(accessToken string) (bool, error) {
return false, nil
}
// GetEmailAddress returns the Account email address
// GetUserDetails returns the Account email address
func (p *GitHubProvider) GetUserDetails(s *sessions.SessionState) (*UserDetails, error) {
var emails []struct {
Email string `json:"email"`

2
providers/gitlab.go
View File

@ -219,7 +219,7 @@ func (p *GitLabProvider) ValidateSessionState(s *sessions.SessionState) bool {
return true
}
// GetEmailAddress returns the Account email address
// GetUserDetails returns the Account email address
func (p *GitLabProvider) GetUserDetails(s *sessions.SessionState) (*UserDetails, error) {
// Retrieve user info
userInfo, err := p.getUserInfo(s)

2
providers/linkedin.go
View File

@ -50,7 +50,7 @@ func getLinkedInHeader(accessToken string) http.Header {
return header
}
// GetEmailAddress returns the Account email address
// GetUserDetails returns the Account email address
func (p *LinkedInProvider) GetUserDetails(s *sessions.SessionState) (*UserDetails, error) {
if s.AccessToken == "" {
return nil, errors.New("missing access token")

7
providers/provider_default.go
View File

@ -117,11 +117,6 @@ func (p *ProviderData) SessionFromCookie(v string, c *encryption.Cipher) (s *ses
return sessions.DecodeSessionState(v, c)
}
// GetEmailAddress returns the Account email address
func (p *ProviderData) GetEmailAddress(s *sessions.SessionState) (string, error) {
return "", errors.New("not implemented")
}
func (p *ProviderData) GetUserDetails(s *sessions.SessionState) (*UserDetails, error) {
return nil, errors.New("not implemented")
}
@ -141,7 +136,7 @@ func (p *ProviderData) ValidateGroup(email string) bool {
return true
}
// ValidateExemptions checks if we can allow user login dispite group membership returned failure
// ValidateExemptions checks if we can allow user login despite group membership returned failure
func (p *ProviderData) ValidateExemptions(*sessions.SessionState) (bool, string) {
return false, ""
}

1
providers/providers.go
View File

@ -8,7 +8,6 @@ import (
// Provider represents an upstream identity provider implementation
type Provider interface {
Data() *ProviderData
GetEmailAddress(*sessions.SessionState) (string, error)
GetUserDetails(*sessions.SessionState) (*UserDetails, error)
GetUserName(*sessions.SessionState) (string, error)
GetGroups(*sessions.SessionState, string) (map[string]string, error)