actions/download-artifact
1
0
Fork 0
mirror of https://github.com/actions/download-artifact.git synced 2024-11-22 21:55:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: ensure that the right version of NodeJS is installed

Browse Source 
It's smart to keep the NodeJS version pinned so we can run all build jobs
consistently.

Otherwise, we might run into some versions mismatch like below:
```
npm ERR! While resolving: @typescript-eslint/parser@2.30.0
npm ERR! Found: eslint@7.4.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^7.4.0" from the root project
npm ERR!   peer eslint@"^5.0.0 || ^6.0.0 || ^7.0.0" from @typescript-eslint/eslint-plugin@4.11.1
npm ERR!   node_modules/@typescript-eslint/eslint-plugin
npm ERR! @typescript-eslint/eslint-plugin@">=2.25.0" from eslint-plugin-github@4.1.1
npm ERR! node_modules/eslint-plugin-github
npm ERR!   dev eslint-plugin-github@"^4.1.1" from the root project
npm ERR!   7 more (@typescript-eslint/experimental-utils, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^5.0.0 || ^6.0.0" from @typescript-eslint/parser@2.30.0
npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   dev @typescript-eslint/parser@"^2.30.0" from the root project
npm ERR!   @typescript-eslint/parser@">=2.25.0" from eslint-plugin-github@4.1.1
npm ERR!   node_modules/eslint-plugin-github
npm ERR! dev eslint-plugin-github@"^4.1.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: eslint@6.8.0
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^5.0.0 || ^6.0.0" from @typescript-eslint/parser@2.30.0
npm ERR!   node_modules/@typescript-eslint/parser
npm ERR! dev @typescript-eslint/parser@"^2.30.0" from the root project
npm ERR! @typescript-eslint/parser@">=2.25.0" from eslint-plugin-github@4.1.1
npm ERR! node_modules/eslint-plugin-github
npm ERR!   dev eslint-plugin-github@"^4.1.1" from the root project
```
This commit is contained in:
Diogo Kiss 2022-10-13 13:53:17 +02:00
parent 22396b7df5
commit db818027c2
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/check-dist.yml vendored
View File

@ -4,7 +4,7 @@
# For our project, we generate this file through a build process # For our project, we generate this file through a build process
# from other source files. # from other source files.
# We need to make sure the checked-in `index.js` actually matches what we expect it to be. # We need to make sure the checked-in `index.js` actually matches what we expect it to be.
name: Check dist/ name: Check dist
on: on:
push: push:

3
.github/workflows/licensed.yml vendored
View File

@ -14,6 +14,9 @@ jobs:
name: Check licenses name: Check licenses
steps: steps:
- uses: actions/checkout@v2 - uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12.x
- run: npm ci - run: npm ci
- name: Install licensed - name: Install licensed
run: | run: |