From 5df67a0f3fd49cfda07b13dae580114dc2e96664 Mon Sep 17 00:00:00 2001 From: Konrad Pabjan Date: Wed, 4 Jan 2023 20:21:02 +0000 Subject: [PATCH] Use node 16 for CI + devcontainer --- .devcontainer/devcontainer.json | 2 +- .github/workflows/check-dist.yml | 6 +++--- .github/workflows/test.yml | 5 +++-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 1ec5f1f..04e180a 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -2,5 +2,5 @@ // README at: https://github.com/devcontainers/templates/tree/main/src/typescript-node { "name": "@actions/download-artifact", - "image": "mcr.microsoft.com/devcontainers/typescript-node:0-18" + "image": "mcr.microsoft.com/devcontainers/typescript-node:0-16" } diff --git a/.github/workflows/check-dist.yml b/.github/workflows/check-dist.yml index 4b0fd80..3a2344f 100644 --- a/.github/workflows/check-dist.yml +++ b/.github/workflows/check-dist.yml @@ -24,10 +24,10 @@ jobs: steps: - uses: actions/checkout@v3 - - name: Setup Node 18 + - name: Setup Node 16 uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 16.x cache: 'npm' - name: Install dependencies @@ -46,7 +46,7 @@ jobs: id: diff # If index.js was different than expected, upload the expected version as an artifact - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v3 if: ${{ failure() && steps.diff.conclusion == 'failure' }} with: name: dist diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3be8491..47cc4da 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -23,10 +23,11 @@ jobs: - name: Checkout uses: actions/checkout@v3 - - name: Setup Node 18 + # using node 16 since that is what the latest version of the runner ships with + - name: Setup Node 16 uses: actions/setup-node@v3 with: - node-version: 18.x + node-version: 16.x cache: 'npm' - name: npm install